Toggle is the most preferable option
I also think the "We can redesign the ability, so it works on the same general theme but functionally is different. For example, it could spawn beams of light nearby - standing in them provides the light boost, while standing out of them provides the shadow boost" is interesting but is just more work for the same thing as the toggle.